Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33661 )
Change subject: vendorcode/google: load sar config from CBFS first then VPD
......................................................................
Patch Set 1:
Quick question: Do we want to still continue supporting SAR in VPD?
It'd certainly be simpler to just require CBFS.
My suggestion is yes and the reason is to reduce the dependency to the FW (no necessary to up-rev FW). And after SAR value is reviewed, factory test can still verify the value.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33661
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5aa6235fb7a6d0b2ed52893a42f7bd57806af6c1
Gerrit-Change-Number: 33661
Gerrit-PatchSet: 1
Gerrit-Owner: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-Comment-Date: Wed, 10 Jul 2019 00:06:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment