[coreboot-gerrit] [S] Change in coreboot[main]: mb/starlabs/*: Set all I2C speeds to fast

[Sean Rhodes (Code Review)]

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84736?usp=email )

(

6 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
 )Change subject: mb/starlabs/*: Set all I2C speeds to fast
......................................................................

mb/starlabs/*: Set all I2C speeds to fast

The default i2c speed is I2C_SPEED_STANDARD, but the coreboot
driver defaults to I2C_SPEED_FAST.

The difference in performance and power consumption is
negligible, so set the buses to fast and remove the
superfluous option.

Change-Id: Ic722e971e6f94965d28fd158a46d144a19490199
Signed-off-by: Sean Rhodes 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84736
Tested-by: build bot (Jenkins) 
Reviewed-by: Matt DeVillier 
---
M src/mainboard/starlabs/starbook/variants/adl/devicetree.cb
M src/mainboard/starlabs/starbook/variants/cml/devicetree.cb
M src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb
M src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb
M src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb
M src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb
M src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c
7 files changed, 39 insertions(+), 6 deletions(-)

Approvals:
  Matt DeVillier: Looks good to me, approved
  build bot (Jenkins): Verified

diff --git a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb
index 8b4daf6..ce5bda4 100644
--- a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb
+++ b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb
@@ -8,6 +8,12 @@
    	[PchSerialIoIndexI2C0]		= PchSerialIoPci,
    }"

+	register "common_soc_config" = "{
+		.i2c[0] = {
+			.speed				= I2C_SPEED_FAST,
+		},
+	}"
+
    register "serial_io_uart_mode" = "{
    	[PchSerialIoIndexUART0]		= PchSerialIoSkipInit,
    }"
diff --git a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb
index db646e3..6769ac9 100644
--- a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb
+++ b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb
@@ -21,6 +21,12 @@
    	[PchSerialIoIndexUART2]		= PchSerialIoSkipInit,
    }"

+	register "common_soc_config" = "{
+		.i2c[0] = {
+			.speed				= I2C_SPEED_FAST,
+		},
+	}"
+
    # Power
    register "PchPmSlpS3MinAssert"		= "2"				# 50ms
    register "PchPmSlpS4MinAssert"		= "3"				# 1s
diff --git a/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb
index 21c475e..a594f7a 100644
--- a/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb
+++ b/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb
@@ -20,6 +20,12 @@
    	[PchSerialIoIndexUart2]		= PchSerialIoSkipInit,
    }"

+	register "common_soc_config" = "{
+		.i2c[0] = {
+			.speed				= I2C_SPEED_FAST,
+		},
+	}"
+
    # Power
    register "PmConfigSlpS3MinAssert"	= "2"				# 50ms
    register "PmConfigSlpS4MinAssert"	= "3"				# 1s
diff --git a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb
index 8889cf6..7faf157 100644
--- a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb
+++ b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb
@@ -10,6 +10,12 @@
    	[PchSerialIoIndexI2C0]			= PchSerialIoPci,
    }"

+	register "common_soc_config" = "{
+		.i2c[0] = {
+			.speed				= I2C_SPEED_FAST,
+		},
+	}"
+
    register "serial_io_uart_mode" = "{
    	[PchSerialIoIndexUART0]			= PchSerialIoSkipInit,
    }"
diff --git a/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb
index 9f208b9..c221285 100644
--- a/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb
+++ b/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb
@@ -22,6 +22,12 @@
    	[PchSerialIoIndexI2C4]		= PchSerialIoSkipInit,
    }"

+	register "common_soc_config" = "{
+		.i2c[0] = {
+			.speed				= I2C_SPEED_FAST,
+		},
+	}"
+
    register "SerialIoUartMode" = "{
    	[PchSerialIoIndexUART2]		= PchSerialIoSkipInit,
    }"
diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb
index 3d49cc1..e1cb6bd 100644
--- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb
+++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb
@@ -11,6 +11,15 @@
    	[PchSerialIoIndexI2C2]		= PchSerialIoPci,
    }"

+	register "common_soc_config" = "{
+		.i2c[0] = {
+			.speed				= I2C_SPEED_FAST,
+		},
+		.i2c[2] = {
+			.speed				= I2C_SPEED_FAST,
+		}
+	}"
+
    register "serial_io_uart_mode" = "{
    	[PchSerialIoIndexUART0]		= PchSerialIoSkipInit,
    }"
diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c
index 8c35c5c..6067a46 100644
--- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c
+++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c
@@ -68,10 +68,4 @@
    /* Enable/Disable Accelerometer based on CMOS settings */
    if (get_uint_option("accelerometer", 1) == 0)
    	accelerometer_dev->enabled = 0;
-
-	/* Set I2C devices speed to fast based on CMOS settings */
-	if (get_uint_option("i2c_speed_fast", 0) == 1) {
-		common_config->i2c[0].speed = I2C_SPEED_FAST;
-		common_config->i2c[2].speed = I2C_SPEED_FAST;
-	}
 }