Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35638 )
Change subject: mb/google/drallion: Configure LPSS controller parameters
......................................................................
Patch Set 3:
Patch Set 3:
I think we can disable non-used I2C, we use the 0,1,4 and 2,3,5 is not used.
Ok, this code would set it to disable anyways.
if (!dev || !dev->enabled)
return PCH_SERIAL_IO_INDEX(PchSerialIoDisabled);
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35638
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c57f8054f5da5add667168502ebc3e089c440f8
Gerrit-Change-Number: 35638
Gerrit-PatchSet: 3
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Chiranjeevi Rapolu
chiranjeevi.rapolu@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 27 Sep 2019 14:51:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment