Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33395 )
Change subject: mb/google/octopus: Override VBT selection for Garg ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/#/c/33395/3/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/garg/mainboard.c:
https://review.coreboot.org/#/c/33395/3/src/mainboard/google/octopus/variant... PS3, Line 1: /*
Rename this file to variant. […]
Done
https://review.coreboot.org/#/c/33395/3/src/mainboard/google/octopus/variant... PS3, Line 4: 2018
2019
Done
https://review.coreboot.org/#/c/33395/3/src/mainboard/google/octopus/variant... PS3, Line 30: google_chromeec_cbi_get_sku_id
Can you please use get_board_sku from src/mainboard/google/octopus/mainboard.c. […]
Hi Karthik, it looks to me get_board_sku will do the same thing (invoke google_chromeec_cbi_get_sku_id as well). besides get_board_sku is a static function, it won't be able to call from outer files. thanks.