build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47357 )
Change subject: WIP: spm: Code to dump back the content ......................................................................
Patch Set 1:
(8 comments)
https://review.coreboot.org/c/coreboot/+/47357/1/src/soc/mediatek/mt8192/spm... File src/soc/mediatek/mt8192/spm.c:
https://review.coreboot.org/c/coreboot/+/47357/1/src/soc/mediatek/mt8192/spm... PS1, Line 532: printk(BIOS_INFO, "spm md32pcm_dma0_rlct @%08lx\n", (long)&mtk_spm->md32pcm_dma0_rlct); line over 96 characters
https://review.coreboot.org/c/coreboot/+/47357/1/src/soc/mediatek/mt8192/spm... PS1, Line 549: printk(BIOS_INFO, "SPM con0 0x%08x/0x%08x\n", con0, con0 | SPM_REGWR_CFG_KEY | PCM_CK_EN_LSB); line over 96 characters
https://review.coreboot.org/c/coreboot/+/47357/1/src/soc/mediatek/mt8192/spm... PS1, Line 586: printk(BIOS_INFO, "spm md32pcm_dma0_rlct @%08lx\n", (long)&mtk_spm->md32pcm_dma0_rlct); line over 96 characters
https://review.coreboot.org/c/coreboot/+/47357/1/src/soc/mediatek/mt8192/spm... PS1, Line 587: for (i = 0; i < ARRAY_SIZE(rlct); i++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/47357/1/src/soc/mediatek/mt8192/spm... PS1, Line 647: printk(BIOS_INFO, "spm md32pcm_dma0_rlct @%08lx\n", (long)&mtk_spm->md32pcm_dma0_rlct); line over 96 characters
https://review.coreboot.org/c/coreboot/+/47357/1/src/soc/mediatek/mt8192/spm... PS1, Line 648: for (i = 0; i < ARRAY_SIZE(rlct); i++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/47357/1/src/soc/mediatek/mt8192/spm... PS1, Line 875: u32* p = (u32 *)mtk_spm; "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/47357/1/src/soc/mediatek/mt8192/spm... PS1, Line 882: int spm_init(void) { open brace '{' following function definitions go on the next line