Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40869 )
Change subject: soc/amd/picasso: add Kconfig option to disable rom sharing
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40869/1/src/soc/amd/common/block/in...
File src/soc/amd/common/block/include/amdblocks/lpc.h:
https://review.coreboot.org/c/coreboot/+/40869/1/src/soc/amd/common/block/in...
PS1, Line 13: #define VW_ROM_SHARING_EN BIT(3)
: #define EXT_ROM_SHARING_EN BIT(4)
In that case we should also move the disable_rom_sharing() to common/block/lpc/lpc. […]
I feel better that I didn't add these defines here. I guess that seems like the proper place along w/ the proper guards.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40869
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60ba852070dd218c4ac071b6c1cfcde2df8e5dce
Gerrit-Change-Number: 40869
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 01 May 2020 23:51:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment