Attention is currently required from: Jason Glenesk, Marshall Dawson, Kyösti Mälkki, Felix Held.
Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48719 )
Change subject: ACPI: Have single call-site for acpi_inject_nvsa()
......................................................................
Patch Set 9: Code-Review+2
(1 comment)
Patchset:
PS9:
Even though I believe we can still leave the south cluster inject entry for future usage, and silicon vendor can still decide they want to add some extra changes other than nvs update or anything else. But current implementation did looks more neat. Hence +2 cast here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48719
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I61a9b07ec3fdaeef0622df82e106405f01e89a9e
Gerrit-Change-Number: 48719
Gerrit-PatchSet: 9
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 13 Jan 2021 03:49:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment