Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35025 )
Change subject: soc/{amd, intel}: Make use of common postcar_enable_tseg_cache() API
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35025/6/src/soc/amd/picasso/romstag...
File src/soc/amd/picasso/romstage.c:
https://review.coreboot.org/c/coreboot/+/35025/6/src/soc/amd/picasso/romstag...
PS6, Line 89: if (CONFIG(SMM_TSEG))
Now that the call is in platform code, the conditional is unnecessary. In common code it would have been necessary to have it to handle AGESA (POSTCAR_STAGE=Y, SMM_ASEG=y) cases where we do not implement smm_region().
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35025
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I18a032b43a2093c8ae86735c119d8dfee40570b1
Gerrit-Change-Number: 35025
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 11 Sep 2019 03:44:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment