Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32407 )
Change subject: soc/amd/picasso: Create picasso as a copy of stoneyridge ......................................................................
Patch Set 1:
Silverback was supposed to go back and fix any issues with the Stoney code. I was under the impression that that was already done, as all outstanding bugs were fixed. If it's not, please help identify areas that need improvement and I'll work to get things changed. This is especially important as it IS being used as a base for the Picasso work.
With original AGESA work S3 suspend support was submitted as "working". Just that it always wrote 32 KiB of SPI flash on every boot. And corrupted low memory on resume. It was neither AMD or Silverback that fixed those, but me.
'Reported bugs fixed' does not equal 'Good code that needs no review'.
I don't have bugfixes to report, just an implementation of the AGESA API tha was completely incomprehensible to the staff to deal with and here are more recent proofs of that:
https://review.coreboot.org/c/coreboot/+/27112 https://review.coreboot.org/c/coreboot/+/27277
On the issue of releasing the StoneyPI code, AMD did agree to release it, but when they started
working towards that, found that because of internal issues, they had no way to do that. I don't even know what to say beyond that. :( I'm sorry, I didn't get it written into a contract and I have no way to force the issue.
Yeah.. decisions like that will likely keep me away from any picasso reviews. Take it as a blessing or a loss.