Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49213 )
Change subject: soc/intel/common/uart: Use simple(_s_) variants of PCI functions
......................................................................
Patch Set 2:
That is where I am planning to head towards eventually. But, it requires adding aliases for the SoCs and updating all relevant common/ and soc/ specific code. Until I can get there I am taking smaller steps to clean up in little chunks to get some space freed up for mainboards that are hitting the limit for bootblock.
What limit for bootblock? C_ENV_BOOTBLOCK_SIZE is artificial and could be dropped, CB:47600. For certain platforms reducing .text alone also does not help because increasing .bss can also move _start16bit too far away from .reset.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49213
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I344037828118572ae5eb27c82c496d5e7a508a53
Gerrit-Change-Number: 49213
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 07 Jan 2021 08:36:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment