Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45826 )
Change subject: soc/intel/icl: enable common CPU code ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45826/2/src/soc/intel/icelake/romst... File src/soc/intel/icelake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/45826/2/src/soc/intel/icelake/romst... PS2, Line 59: m_cfg->VmxEnable = CONFIG(ENABLE_VMX);
Better than yet another `if`?
There is no `if`, when we use variant 1. set_vmx_and_lock() must be called explicitly in soc code. When we don't call it, because FSP does everything, the Kconfigs won't do anything.
If we want to do it ourselves, we'd need to set VmxEnable=0 always and call set_vmx_and_lock(). Then the user has full control.
So, the question is 1) let FSP do and fake force-enable Kconfig or 2) keep FSP from doing anything (VmxEnable=0) and call set_vmx_and_lock(), which does not need hacking Kconfig.