Attention is currently required from: Pratikkumar Prajapati.
Hello Pratikkumar Prajapati,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/77236?usp=email
to review the following change.
Change subject: soc/intel/common: Rename crashlog macros ......................................................................
soc/intel/common: Rename crashlog macros
Remove MAILBOX word from CPU_CRASHLOG_MAILBOX_WAIT_STALL and CPU_CRASHLOG_MAILBOX_WAIT_TIMEOUT macros, because they can be used for other interface as well.
BUG=b:262501347 TEST=Able to build REX.
Change-Id: I62b04fa4b05c427db494a536ca6504db02dfeb68 Signed-off-by: Pratikkumar Prajapati pratikkumar.v.prajapati@intel.corp-partner.google.com --- M src/soc/intel/common/block/crashlog/crashlog.c M src/soc/intel/common/block/include/intelblocks/crashlog.h 2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/77236/1
diff --git a/src/soc/intel/common/block/crashlog/crashlog.c b/src/soc/intel/common/block/crashlog/crashlog.c index 5b098bb..fa36033 100644 --- a/src/soc/intel/common/block/crashlog/crashlog.c +++ b/src/soc/intel/common/block/crashlog/crashlog.c @@ -114,13 +114,13 @@
do { cl_mailbox_interface.data = read32((u32 *)cl_mailbox_addr); - udelay(CPU_CRASHLOG_MAILBOX_WAIT_STALL); + udelay(CPU_CRASHLOG_WAIT_STALL); stall_cnt++; } while ((cl_mailbox_interface.fields.busy == 1) - && stall_cnt < CPU_CRASHLOG_MAILBOX_WAIT_TIMEOUT); + && stall_cnt < CPU_CRASHLOG_WAIT_TIMEOUT);
if ((cl_mailbox_interface.fields.busy == 1) - && (stall_cnt >= CPU_CRASHLOG_MAILBOX_WAIT_TIMEOUT)) { + && (stall_cnt >= CPU_CRASHLOG_WAIT_TIMEOUT)) { printk(BIOS_ERR, "CPU crashlog mailbox timed out.\n"); return 0; } diff --git a/src/soc/intel/common/block/include/intelblocks/crashlog.h b/src/soc/intel/common/block/include/intelblocks/crashlog.h index 7d3252a..749f63f 100644 --- a/src/soc/intel/common/block/include/intelblocks/crashlog.h +++ b/src/soc/intel/common/block/include/intelblocks/crashlog.h @@ -17,8 +17,8 @@ /* CPU CrashLog Mailbox commands */ #define CPU_CRASHLOG_CMD_DISABLE 0 #define CPU_CRASHLOG_CMD_CLEAR 2 -#define CPU_CRASHLOG_MAILBOX_WAIT_STALL 1 -#define CPU_CRASHLOG_MAILBOX_WAIT_TIMEOUT 1000 +#define CPU_CRASHLOG_WAIT_STALL 1 +#define CPU_CRASHLOG_WAIT_TIMEOUT 1000 #define CPU_CRASHLOG_DISC_TAB_GUID_VALID 0x1600
#define CRASHLOG_SIZE_DEBUG_PURPOSE 0x640