Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34535 )
Change subject: lib: Throw an error when ramdisk is present but initrd.size is 0
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34535/13/src/lib/fit_payload.c
File src/lib/fit_payload.c:
https://review.coreboot.org/c/coreboot/+/34535/13/src/lib/fit_payload.c@46
PS13, Line 46: * Returns true on error, false on success.
I can add a comment in this CL if it's needed.
Let's keep that discussion in the other patch and address it separately, it has nothing to do with this. Just mark the outstanding comments as resolved and we can merge this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34535
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85aa33d2c2846b6b3a58df834dda18c47433257d
Gerrit-Change-Number: 34535
Gerrit-PatchSet: 13
Gerrit-Owner: Asami Doi
d0iasm.pub@gmail.com
Gerrit-Reviewer: Asami Doi
d0iasm.pub@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 05 Aug 2019 20:45:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Comment-In-Reply-To: Asami Doi
d0iasm.pub@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment