Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45336 )
Change subject: soc/intel/common/block: Add Intel common reset code ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45336/7/src/soc/intel/common/block/... File src/soc/intel/common/block/reset/reset.c:
https://review.coreboot.org/c/coreboot/+/45336/7/src/soc/intel/common/block/... PS7, Line 27: do_force_global_reset
Second, do_global_reset is only ever called from do_force_global_reset, so why not move the prior to the latter?
do_global_reset() is calling from below common reference hence we might need to change that code as well to make something meaning full. Finally do_force_global_reset() can be renamed as pmc_assist_global_reset() which is the actual case ?
See, how I am confused? :P Actually I meant "do_force_global_reset is only ever called from do_global_reset".
What about this?
static void force_global_reset(void) { if (cse_request_global_reset()) return; /* TODO: or halt()? */
/* * If ME is unable to reset platform then enable the PMC CF9GR register and * force a global reset by writing 0x06 or 0x0E. */
pmc_global_reset_enable(true);  /* Now BIOS can write 0x06 or 0x0E to 0xCF9 port to global reset platform */  do_full_reset(); // another really_really_do_... ;-) }