Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34778 )
Change subject: soc/mediatek: Change DSI init commands to take flexible length array
......................................................................
Patch Set 24:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34778/12/src/soc/mediatek/common/ds...
File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/34778/12/src/soc/mediatek/common/ds...
PS12, Line 333: */
Please use one of the allowed comment styles from the coding style.
Done
https://review.coreboot.org/c/coreboot/+/34778/13/src/soc/mediatek/common/ds...
File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/34778/13/src/soc/mediatek/common/ds...
PS13, Line 347: buf += sizeof(*init);
nit: why not do the whole […]
because if command is delay, len must be ignored.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34778
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I359dde8e6f2e1c0983f4677193bb47a7ae497ca6
Gerrit-Change-Number: 34778
Gerrit-PatchSet: 24
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nicolas Boichat
drinkcat@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 15 Aug 2019 01:13:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment