Attention is currently required from: Kevin Chiu, Nick Vaccaro, Shon Wang. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59305 )
Change subject: mb/google/brya/var/vell: update gpio override ......................................................................
Patch Set 9:
(7 comments)
File src/mainboard/google/brya/variants/vell/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134423): https://review.coreboot.org/c/coreboot/+/59305/comment/0438e648_ce20eb2c PS9, Line 151: /* B4 : PROC_GP3 ==> SSD_PERST_L */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134423): https://review.coreboot.org/c/coreboot/+/59305/comment/2eca19ea_f18d8f92 PS9, Line 152: PAD_CFG_GPO(GPP_B4, 1, DEEP), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134423): https://review.coreboot.org/c/coreboot/+/59305/comment/51568b14_567d51e5 PS9, Line 152: PAD_CFG_GPO(GPP_B4, 1, DEEP), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134423): https://review.coreboot.org/c/coreboot/+/59305/comment/9ba6427d_d7b4fd02 PS9, Line 157: *num = ARRAY_SIZE(romstage_gpio_table); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134423): https://review.coreboot.org/c/coreboot/+/59305/comment/50c8a8c2_a873ef40 PS9, Line 157: *num = ARRAY_SIZE(romstage_gpio_table); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134423): https://review.coreboot.org/c/coreboot/+/59305/comment/6282bb67_750b8360 PS9, Line 158: return romstage_gpio_table; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134423): https://review.coreboot.org/c/coreboot/+/59305/comment/63fc1124_00d7bdaa PS9, Line 158: return romstage_gpio_table; please, no spaces at the start of a line