14 May
2019
14 May
'19
2:44 p.m.
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31488 )
Change subject: soc/amd/common: Identify AGESA call pattern ......................................................................
Patch Set 5:
(1 comment)
Convoluted, but appears to be correct.
https://review.coreboot.org/#/c/31488/5/src/soc/amd/common/block/pi/agesawra... File src/soc/amd/common/block/pi/agesawrapper.c:
https://review.coreboot.org/#/c/31488/5/src/soc/amd/common/block/pi/agesawra... PS5, Line 68: AGESA_STATUS Why return status if it won't be used outside create struct?
--
To view, visit https://review.coreboot.org/c/coreboot/+/31488
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1037c9daef3365c8672a198ac60f47fc79ffaea1
Gerrit-Change-Number: 31488
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 14 May 2019 21:44:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment