Attention is currently required from: Robert Zieba, Jason Glenesk, Raul Rangel, Marshall Dawson, Kangheui Won, Jon Murphy, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60290 )
Change subject: util/amdfwtool: Generate hashes for signed AMDFW components
......................................................................
Patch Set 15:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/60290/comment/48e41b53_9ac11d59
PS14, Line 1065: signed_rom_hash_strlen = strlen(signed_rom) + strlen(HASH_FILE_SUFFIX) + 1;
Is it worth adding a comment that the additional byte is for the NULL termination character? I'm go […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60290
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I50d278536ba1eac754eb8a39c4c2e428a2371c44
Gerrit-Change-Number: 60290
Gerrit-PatchSet: 15
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Robert Zieba
robertzieba@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 30 Sep 2022 20:44:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jon Murphy
jpmurphy@google.com
Gerrit-MessageType: comment