Venkata Krishna Nimmagadda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40259 )
Change subject: soc/intel/common: Add _DSM methods for LPIT table ......................................................................
Patch Set 4:
(6 comments)
https://review.coreboot.org/c/coreboot/+/40259/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40259/4//COMMIT_MSG@11 PS4, Line 11: : LPIT table is hardcoded in this patch but the proper way to implement : is to use inject_dsdt to make the _DSM methods available for soc's to : implement.
Do you have plans for a follow-up to address this too?
Right, let me try to address it. We can't dodge this forever.But should it be done in this patch itself?
https://review.coreboot.org/c/coreboot/+/40259/3/src/soc/intel/common/acpi/l... File src/soc/intel/common/acpi/lpit.asl:
https://review.coreboot.org/c/coreboot/+/40259/3/src/soc/intel/common/acpi/l... PS3, Line 37: 2
Can we make a #define for this too? […]
sorry didn't catch it myself. Done now
https://review.coreboot.org/c/coreboot/+/40259/3/src/soc/intel/common/acpi/l... PS3, Line 43: 3
Can we make a #define for this too? […]
Done
https://review.coreboot.org/c/coreboot/+/40259/3/src/soc/intel/common/acpi/l... PS3, Line 48: 4
Can we make a #define for this too? […]
Done
https://review.coreboot.org/c/coreboot/+/40259/3/src/soc/intel/common/acpi/l... PS3, Line 53: 5
Can we make a #define for this too? […]
Done
https://review.coreboot.org/c/coreboot/+/40259/3/src/soc/intel/common/acpi/l... PS3, Line 76: 6
Can we make a #define for this too? […]
Done