15 Feb
2020
15 Feb
'20
9:50 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/38264 )
Change subject: gma bxt panel: Correct power-cycle delay programming ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/libgfxinit/+/38264/1/common/hw-gfx-gma-panel.a... File common/hw-gfx-gma-panel.adb:
https://review.coreboot.org/c/libgfxinit/+/38264/1/common/hw-gfx-gma-panel.a... PS1, Line 81: function BXT_PP_CONTROL_PWR_CYC_DELAY (US : Natural) return Word32 is
Actually, I could make it an expression function, would at least save some […]
That looks much better, thanks!
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/38264
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: Iff53ef5730691c3be1ebcda71428e2bfe9ae16fd
Gerrit-Change-Number: 38264
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Sat, 15 Feb 2020 21:50:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment