build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42810 )
Change subject: soc/amd/picasso: Halt if workbuf is absent after psp_verstage ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42810/3/src/soc/amd/picasso/bootblo... File src/soc/amd/picasso/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/42810/3/src/soc/amd/picasso/bootblo... PS3, Line 134: printk(BIOS_ERR,"ERROR: VBOOT workbuf not valid.\n"); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42810/3/src/soc/amd/picasso/bootblo... PS3, Line 136: printk(BIOS_DEBUG,"Signature: %#08x\n",*(uint32_t *)_vboot2_work); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42810/3/src/soc/amd/picasso/bootblo... PS3, Line 136: printk(BIOS_DEBUG,"Signature: %#08x\n",*(uint32_t *)_vboot2_work); space required after that ',' (ctx:VxO)
https://review.coreboot.org/c/coreboot/+/42810/3/src/soc/amd/picasso/bootblo... PS3, Line 136: printk(BIOS_DEBUG,"Signature: %#08x\n",*(uint32_t *)_vboot2_work); space required before that '*' (ctx:OxV)