Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31724 )
Change subject: mb/google/hatch: Initialize all gpios
......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/31724/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31724/1//COMMIT_MSG@7
PS1, Line 7: gpios
GPIOs
https://review.coreboot.org/#/c/31724/1//COMMIT_MSG@8
PS1, Line 8:
Please elaborate what values they are initialized to.
https://review.coreboot.org/#/c/31724/1//COMMIT_MSG@11
PS1, Line 11: BIOS
firmware
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31724
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e41f0b38703f2c7a2b5a7ac9b108f8f10070004
Gerrit-Change-Number: 31724
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 Mar 2019 12:26:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment