Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35772 )
Change subject: nb/intel/nehalem: Move PCH init to sb/intel/ibexpeak
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35772/6/src/mainboard/packardbell/m...
File src/mainboard/packardbell/ms2290/romstage.c:
https://review.coreboot.org/c/coreboot/+/35772/6/src/mainboard/packardbell/m...
PS6, Line 32: pci_write_config32(PCH_LPC_DEV, LPC_GEN1_DEC, (0x68 & ~3) | 0x00040001);
are lpc gen dec present in devicetree already? Would be great if you could state that in the commit message
There was already ramstage code to do that based on the devicetree. I'll update the commit message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35772
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f448ad1fdc445c4c1fedbc8497e1025af111412
Gerrit-Change-Number: 35772
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 03 Oct 2019 10:21:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment