Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33839 )
Change subject: mb/protectli/vault_kbl: Add FW6 support ......................................................................
Patch Set 8:
(6 comments)
https://review.coreboot.org/c/coreboot/+/33839/8/Documentation/mainboard/pro... File Documentation/mainboard/protectli/fw6.jpg:
PS8: Would it be possible to have a picture of the internals instead?
https://review.coreboot.org/c/coreboot/+/33839/8/Documentation/mainboard/pro... File Documentation/mainboard/protectli/fw6.md:
https://review.coreboot.org/c/coreboot/+/33839/8/Documentation/mainboard/pro... PS8, Line 28: microcode Capitalize?
https://review.coreboot.org/c/coreboot/+/33839/8/Documentation/mainboard/pro... PS8, Line 31: graphics in BIOS We're not a steenkin' BIOS! How about: `pre-OS graphics` ?
https://review.coreboot.org/c/coreboot/+/33839/4/src/mainboard/protectli/vau... File src/mainboard/protectli/vault_kbl/Kconfig:
https://review.coreboot.org/c/coreboot/+/33839/4/src/mainboard/protectli/vau... PS4, Line 22: FW6
Board is FW6 and I do not want to change this Kconfig option, because it is propagated to SMBIOS. […]
Ack
https://review.coreboot.org/c/coreboot/+/33839/8/src/mainboard/protectli/vau... File src/mainboard/protectli/vault_kbl/Kconfig:
https://review.coreboot.org/c/coreboot/+/33839/8/src/mainboard/protectli/vau... PS8, Line 46: config INTEL_GMA_VBT_FILE Isn't that the default path?
https://review.coreboot.org/c/coreboot/+/33839/8/src/mainboard/protectli/vau... File src/mainboard/protectli/vault_kbl/acpi_tables.c:
PS8: This can go away