[coreboot-gerrit] [M] Change in coreboot[master]: util/sconfig: Include optional maiboard chip header

[Tim Van Patten (Code Review)]

Attention is currently required from: Raul Rangel, Martin L Roth, Jon Murphy, Arthur Heymans, Angel Pons, Karthik Ramasubramanian, Felix Held.

Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74736 )

Change subject: util/sconfig: Include optional maiboard chip header
......................................................................

Patch Set 3:

(2 comments)

File util/sconfig/main.c:

https://review.coreboot.org/c/coreboot/+/74736/comment/9c6a2379_eb41539d 
PS3, Line 1405: 	free(mainboard_path);
> Everything I'm reading states that double-freeing is undefined behavior (at best) and corrupts the m […]

Chatted offline, I was getting lost. This is only freeing once, since `mainboard_path` = `base_devtree_dir` = `base_devtree_path`, and the other `free` only occurs when that's not the case.

https://review.coreboot.org/c/coreboot/+/74736/comment/32408d3a_83a3be02 
PS3, Line 2030: 		mainboard_path = base_devtree_dir;
> ref1

Ack