Hello Patrick Rudolph, Lance Zhao, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33093
to look at the new patch set (#2).
Change subject: soc/intel/{skl,cnl,icl}: Drop soc_uart_set_legacy_mode() ......................................................................
soc/intel/{skl,cnl,icl}: Drop soc_uart_set_legacy_mode()
This is never called: The only calling path is guarded by both !DRIVERS_UART_8250MEM_32 and INTEL_LPSS_UART_FOR_CONSOLE but the latter selects the former.
If somebody figures out how this is supposed to be used, we can easily revive the implementation.
Change-Id: I96e304bdee4eadb52725027d0d662ef75f3d4307 Signed-off-by: Nico Huber nico.h@gmx.de --- M src/soc/intel/cannonlake/uart.c M src/soc/intel/icelake/uart.c M src/soc/intel/skylake/uart.c 3 files changed, 0 insertions(+), 45 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/33093/2