12 Oct
2020
12 Oct
'20
8:45 p.m.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45610 )
Change subject: northbridge/intel/Kconfig: Introduce and use DEFAUL BARs_ADDRESS symbols ......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45610/14/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/45610/14/src/Kconfig@525 PS14, Line 525: .bars
yes the order matter. […]
sorry, forget to mention that we can just rename "Kconfig.bars" as "Kconfig". Kconfig tool will see symbols defined at the right place (because of alphabetic order: "common" is before "gm45" )
--
To view, visit https://review.coreboot.org/c/coreboot/+/45610
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idca25b2e4bf65abcb3f8b150452ab2567baa60c3
Gerrit-Change-Number: 45610
Gerrit-PatchSet: 14
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 12 Oct 2020 17:45:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr
Gerrit-MessageType: comment