Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45055 )
Change subject: soc/amd/picasso: Fix TSC frequency calculation
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45055/2/src/soc/amd/picasso/tsc_fre...
File src/soc/amd/picasso/tsc_freq.c:
https://review.coreboot.org/c/coreboot/+/45055/2/src/soc/amd/picasso/tsc_fre...
PS2, Line 36: 0x3c
I have been scratching my head on this one from the beginning. […]
Meh, I'd probably lean the other way and go with 0x3e.
https://review.coreboot.org/c/coreboot/+/45055/2/src/soc/amd/picasso/tsc_fre...
PS2, Line 37: mhz = (unsigned long) ((200 * cpufid) / cpudid);
Great point. I am all for more verbose comments. […]
It just took me a bit to understand what you were doing because it didn't match the PPR. Works out the same, of course.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45055
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe3f49c7d295e7336ee042da2b94823171b6eb55
Gerrit-Change-Number: 45055
Gerrit-PatchSet: 3
Gerrit-Owner: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 09 Sep 2020 16:59:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-MessageType: comment