Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34335 )
Change subject: sb/intel/bd82x6x/usb_xhci: Lock OC config and refactoring
......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34335/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34335/3//COMMIT_MSG@7
PS3, Line 7: refactoring
*do refactoring* or *refactor code*
https://review.coreboot.org/c/coreboot/+/34335/3//COMMIT_MSG@19
PS3, Line 19: Untested
Can the successful locking be verified from the OS?
https://review.coreboot.org/c/coreboot/+/34335/3/src/southbridge/intel/bd82x...
File src/southbridge/intel/bd82x6x/usb_xhci.c:
https://review.coreboot.org/c/coreboot/+/34335/3/src/southbridge/intel/bd82x...
PS3, Line 52: XHCC+2
Spaces around the operator?
XHCC + 2
https://review.coreboot.org/c/coreboot/+/34335/3/src/southbridge/intel/bd82x...
PS3, Line 55: XHCC+2
Ditto.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34335
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53fef63de518ae089a6b7ef4483893bbb7c8c44e
Gerrit-Change-Number: 34335
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Alexey Derlaft
derlafff@ya.ru
Gerrit-Reviewer: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marcello Sylvester Bauer
sylvblck@sylv.io
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 15 Jul 2019 12:46:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment