[coreboot-gerrit] Change in ...coreboot[master]: soc/amd: Add support to soc merlinfalcon

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31372 )

Change subject: soc/amd: Add support to soc merlinfalcon
......................................................................

Patch Set 1:

(1 comment)
> Patch Set 1:
>
> (1 comment)

https://review.coreboot.org/#/c/31372/1/src/soc/amd/stoneyridge/include/soc/... 
File src/soc/amd/stoneyridge/include/soc/pci_devs.h:

https://review.coreboot.org/#/c/31372/1/src/soc/amd/stoneyridge/include/soc/... 
PS1, Line 118: #define HT_DEVID_CZ		0x1570
             : #define HT_DEVID_ST		0x15b0
> I don't see that we're using the xxxx_DEVID defines at all. […]

And remove them from here?
As far as I could search, we are not using them, and I don't know why you placed them here, except that it makes easier to whoever wants to use them to know the appropriate value to use.