Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36808 )
Change subject: security/vboot: Remove flags from struct vboot_working_data ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36808/1/src/security/vboot/bootmode... File src/security/vboot/bootmode.c:
https://review.coreboot.org/c/coreboot/+/36808/1/src/security/vboot/bootmode... PS1, Line 151: cbmem_possibly_online() If this function is executed after verstage, but before cbmem comes up, I think it will always return 0.
Perhaps we should change it to look something like vboot_check_recovery_request()?
return vboot_possibly_executed() && vboot_logic_executed() && (flags & DEV_MODE);
(Although I'm still not entirely sure why we need vboot_possibly_executed() here.)