Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40351 )
Change subject: mb/dell/optiplex_9010: Add Dell OptiPlex 9010 SFF support
......................................................................
Patch Set 17:
(1 comment)
Also added DP1 and DP2 to the GMA port list. When testing coreboot on another OptiPlex 9010 the Display Ports were not enabled by libgfxinit. It seems some of the PCs use HDMI, some use DP...
https://review.coreboot.org/c/coreboot/+/40351/16/src/mainboard/dell/optiple...
File src/mainboard/dell/optiplex_9010/mainboard.c:
https://review.coreboot.org/c/coreboot/+/40351/16/src/mainboard/dell/optiple...
PS16, Line 2: /* This file is part of the coreboot project. */
please remove these lines; see https://review.coreboot. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40351
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88d65cae30d08ca727d86d930707c2be25a527cf
Gerrit-Change-Number: 40351
Gerrit-PatchSet: 17
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sat, 16 May 2020 17:24:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment