Attention is currently required from: Sean Rhodes, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58798 )
Change subject: tigerlake/apci: Only use SCM for ChromeOS
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
Patchset:
PS5:
Nice digging Sean!
File src/soc/intel/tigerlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/58798/comment/d77e6f9f_bf12bd7c
PS5, Line 157: #if CONFIG(CHROMEOS)
Can you add a comment here (similar to your commit msg) why this is done?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58798
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib947c3c9cd843e54d4664509c15336178c0bc99e
Gerrit-Change-Number: 58798
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andy Pont
andy.pont@sdcsystems.com
Gerrit-Attention: Sean Rhodes
admin@starlabs.systems
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 04 Nov 2021 15:05:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment