Attention is currently required from: Fabian Groffen, Keith Hui.
Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75137?usp=email )
Change subject: mb/asus/p8z77-m: Remove settings to replicate OEM
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS3:
I did have to change the coin cell on the board, so there was no battery on the board for a while. […]
I found out why S3 didn't work for me, and it was not your patch.
LDA 0x0a CR 0xe4 has to be set to 0x10 which was not done for this board. I'll push a patch to fix. If you want to roll this fix in, feel free.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75137?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iae526762e79e9e2d46d06e12c338f375e5555e8c
Gerrit-Change-Number: 75137
Gerrit-PatchSet: 4
Gerrit-Owner: Fabian Groffen
grobian@gentoo.org
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Keith Hui
buurin@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Keith Hui
buurin@gmail.com
Gerrit-Attention: Fabian Groffen
grobian@gentoo.org
Gerrit-Comment-Date: Sat, 30 Sep 2023 06:36:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Keith Hui
buurin@gmail.com
Comment-In-Reply-To: Fabian Groffen
grobian@gentoo.org
Gerrit-MessageType: comment