Attention is currently required from: Bob Moragues, Paul Menzel, Shyam Sundar Radjacoumar, Subrata Banik.
Karthik Ramasubramanian has posted comments on this change by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/84937?usp=email )
Change subject: mb/google/brox: Hint romstage init about upcoming reset
......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/google/brox/variants/baseboard/brox/romstage.c:
https://review.coreboot.org/c/coreboot/+/84937/comment/637e8267_3087d657?usp... :
PS5, Line 24: ret = google_chromeec_get_num_pd_ports(&num_ports);
: if (ret < 0 || !num_ports) {
: printk(BIOS_INFO, "%s: Cannot resolve # of USB PD ports\n", __func__);
: return mismatch;
: }
I'm wondering if we need to call this API at all. […]
Done
https://review.coreboot.org/c/coreboot/+/84937/comment/57cb9645_7a94886d?usp... :
PS5, Line 30: google_chromeec_get_pd_chip_infoi
is this a typo ? […]
Acknowledged. Fixed the typo in API as well as here. Thanks for catching that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84937?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieed3f9013dee9aa501a3f0403f3a28722a3878f1
Gerrit-Change-Number: 84937
Gerrit-PatchSet: 6
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Bob Moragues
moragues@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Shyam Sundar Radjacoumar
ssradjacoumar@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Shyam Sundar Radjacoumar
ssradjacoumar@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bob Moragues
moragues@chromium.org
Gerrit-Comment-Date: Tue, 05 Nov 2024 19:26:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com