Daniel Kang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46826 )
Change subject: mb/google/volteer: Remove RIPTO support for camera ......................................................................
mb/google/volteer: Remove RIPTO support for camera
GPIO D4 was used for camera reset for both front and rear cameras (RCAM_RST_L/FCAM_RST_L) in RIPTO. For later volteer versions, GPIO F15 is dedicated to the rear camera reset (RCAM_RST_L).
Before, BOARD_GOOGLE_VOLTEER flag was used for setting the right RCAM_RST_L per volteer version. However, we don't support RIPTO anymore. Also using flags for different volteer version support can be error-prone. Removing RIPTO support.
BUG=b:171726823 BRANCH=none TEST=Build and boot volteer proto2 or later version. Camera should work without an issue.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: I961fc17092887b4807c12c95f7139bb7e7b33e91 --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 0 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/46826/1
diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl index a90a62e..bda0d11 100644 --- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl +++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl @@ -156,11 +156,7 @@ MCON(3,1) /* Clock 3, 19.2MHz */
/* Pull RST low */ -#if CONFIG(BOARD_GOOGLE_VOLTEER) CTXS(GPP_F15) -#else - CTXS(GPP_D4) -#endif
/* Pull SNRPWR_EN high */ STXS(GPP_H14) @@ -175,11 +171,7 @@ REFC = REFC + 1
/* Pull RST high */ -#if CONFIG(BOARD_GOOGLE_VOLTEER) STXS(GPP_F15) -#else - STXS(GPP_D4) -#endif
Sleep(1) /* t2 */
@@ -192,11 +184,7 @@ MCOF(3) /* Clock 3 */
/* Pull RST low */ -#if CONFIG(BOARD_GOOGLE_VOLTEER) CTXS(GPP_F15) -#else - CTXS(GPP_D4) -#endif
If ((REFC == 1)) {