Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/44790 ) Change subject: Add Bay Trail options ...................................................................... Patch Set 3: (2 comments) https://review.coreboot.org/c/libgfxinit/+/44790/3/common/hw-gfx-gma-config.... File common/hw-gfx-gma-config.ads.template: https://review.coreboot.org/c/libgfxinit/+/44790/3/common/hw-gfx-gma-config.... PS3, Line 166: -- VLV: False -- c.f. EDS or similar
Time to strip these comments? Oops, true.
https://review.coreboot.org/c/libgfxinit/+/44790/3/configs/baytrail File configs/baytrail: https://review.coreboot.org/c/libgfxinit/+/44790/3/configs/baytrail@1 PS3, Line 1: CONFIG_GFX_GMA_DYN_CPU = y
Only useful when a generation supports more than one CPU/SoC (yet). So, should I remove it? Broxton has this set to nothing
I would also need to specify the CPU here then -- To view, visit https://review.coreboot.org/c/libgfxinit/+/44790 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Ib30ea668da9641ccf1f94f8f25cfb897faa54aaa Gerrit-Change-Number: 44790 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 28 Aug 2020 20:37:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> Gerrit-MessageType: comment