Attention is currently required from: EliasOfWaffle, Eugene Myers, Martin L Roth, Michał Żygowski, Paul Menzel, Stefan Reinauer.
Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78889?usp=email )
Change subject: cpu/x86/smm: Fix get_save_state calculation
......................................................................
Patch Set 2:
(1 comment)
File src/cpu/x86/smm/smm_module_handler.c:
https://review.coreboot.org/c/coreboot/+/78889/comment/69409c9b_cc9d8eab :
PS1, Line 104: size_t stm_psd_size = 0;
I feel like the following is more readable but this is totally optional. […]
```
size_t size = smm_runtime.save_state_size;
if (cpu > smm_runtime.num_cpus)
return NULL;
if (CONFIG(STM))
size -= ALIGN_UP(sizeof(TXT_PROCESSOR_SMM_DESCRIPTOR), 0x100);
return (void *)(smm_runtime.save_state_top[cpu] - size);
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78889?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0233c6d13bdffb3853845ac6ef25c066deaab747
Gerrit-Change-Number: 78889
Gerrit-PatchSet: 2
Gerrit-Owner: Eugene Myers
cedarhouse1@comcast.net
Gerrit-Reviewer: EliasOfWaffle
eliascontato@protonmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Eugene Myers
cedarhouse1@comcast.net
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: EliasOfWaffle
eliascontato@protonmail.com
Gerrit-Comment-Date: Thu, 02 Nov 2023 19:29:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-MessageType: comment