Rasheed Hsueh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48552 )
Change subject: mb/google/octopus/variants/phaser: support new touch panel ic
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48552/3/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/phaser/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48552/3/src/mainboard/google/octopu...
PS3, Line 182: register "generic.reset_delay_ms" = "70"
- I didn't check spec yet and see others set it as 50ms only so may I know where is this 70 came fro […]
Hi Marco,
I'm referencing this CL: 46344.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48552
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib57597c4998f205c664e13befb4c44532b7dbd4f
Gerrit-Change-Number: 48552
Gerrit-PatchSet: 3
Gerrit-Owner: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-CC: Marco Chen
marcochen@google.com
Gerrit-CC: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Comment-Date: Fri, 11 Dec 2020 06:59:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Gerrit-MessageType: comment