cedarhouse1@comcast.net has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37990 )
Change subject: soc/intel: Add get_pmbase
......................................................................
Patch Set 3:
(2 comments)
Will issue a new patch set once I get the smm_segs.h issue resolved.
https://review.coreboot.org/c/coreboot/+/37990/3/src/soc/intel/apollolake/pm...
File src/soc/intel/apollolake/pmutil.c:
https://review.coreboot.org/c/coreboot/+/37990/3/src/soc/intel/apollolake/pm...
PS3, Line 251:
No blank line.
Done
https://review.coreboot.org/c/coreboot/+/37990/3/src/soc/intel/quark/acpi.c
File src/soc/intel/quark/acpi.c:
https://review.coreboot.org/c/coreboot/+/37990/3/src/soc/intel/quark/acpi.c@...
PS3, Line 113: & B_QNC_LPC_PM1BLK_MASK;
Do both lines fit into 96 character line?
No. The first line of code is 101 characters and the second is 92 characters.
So far during the early part of the review the BOT has been complaining when any line of code is over 80 characters. So, I made a big effort to ensure that everything is under 80 lines.
Is this a change?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37990
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6f6295c5eba9eb20e57ab56e7f965c8879e93d2
Gerrit-Change-Number: 37990
Gerrit-PatchSet: 3
Gerrit-Owner: cedarhouse1@comcast.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cedarhouse1@comcast.net
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Jonathan Zhang
jonzhang@fb.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-CC: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Thu, 30 Jan 2020 18:27:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment