Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44476 )
Change subject: ec/kontron/kempld: add option to configure I2C frequency
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44476/12/src/ec/kontron/kempld/kemp...
File src/ec/kontron/kempld/kempld_i2c.c:
https://review.coreboot.org/c/coreboot/+/44476/12/src/ec/kontron/kempld/kemp...
PS12, Line 52: I2C_FREQ_FAST_MODE = 400, /* 400 kHz */
: I2C_FREQ_FAST_PLUS_MODE = 1000, /* 1 MHz */
These two seem unused. Why not make them available through `chip.h`? Then
one can use them in the devicetree. Adding the frequency would make it
more readable, e.g.
I2C_FREQ_FAST_MODE_400KHZ = 400,
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44476
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0eb477af10d00eb4f17f9c01209f170b746ad3d
Gerrit-Change-Number: 44476
Gerrit-PatchSet: 12
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 24 Sep 2020 20:03:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
