[coreboot-gerrit] Change in coreboot[master]: mediatek/mt8183: Implement the dramc init setting

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34988 )

Change subject: mediatek/mt8183: Implement the dramc init setting
......................................................................

Patch Set 22: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/34988/17/src/soc/mediatek/mt8183/dr... 
File src/soc/mediatek/mt8183/dramc_init_setting.c:

https://review.coreboot.org/c/coreboot/+/34988/17/src/soc/mediatek/mt8183/dr... 
PS17, Line 688: u8 MR01Value[FSP_MAX] = {0x26, 0x56};
              : u8 MR13Value = (1 << 4) | (1 << 3);
> Yes I think we should put everything together.

Ack

https://review.coreboot.org/c/coreboot/+/34988/17/src/soc/mediatek/mt8183/dr... 
File src/soc/mediatek/mt8183/dramc_pi_basic_api.c:

https://review.coreboot.org/c/coreboot/+/34988/17/src/soc/mediatek/mt8183/dr... 
PS17, Line 23: impedance
> I'll take a look and try to pass it as a function argument. […]

Let's do that in a follow up clean up, when we've determined all what's needed.