build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 )
Change subject: [WIP] util: Add GUI to change CMOS settings ......................................................................
Patch Set 1:
(43 comments)
File util/coreboot-configurator/README.md:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/e5bcac02_4ce5189c PS1, Line 25: echo "deb http://ppa.launchpad.net/starlabs/ppa/ubuntu focal main" | sudo tee -a /etc/apt/sources.list.d/starlabs-ubuntu-ppa-focal.list trailing whitespace
File util/coreboot-configurator/debian/changelog:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/c5ab5103_e179c966 PS1, Line 24: * Added qt5-default dependancy 'dependancy' may be misspelled - perhaps 'dependency'?
File util/coreboot-configurator/src/labtop-series/aboutwindow.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/30e24eeb_18a0dbac PS1, Line 15: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/0a7286a2_a7d397b5 PS1, Line 15: public: labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/c0a1c3ca_ff29bfba PS1, Line 16: explicit aboutWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/79a50ca4_b4248a7f PS1, Line 19: private: labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/e60a7786_3b237079 PS1, Line 20: Ui::aboutWindow *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/22f73df5_fd55b04d PS1, Line 20: Ui::aboutWindow *ui; labels should not be indented
File util/coreboot-configurator/src/labtop-series/coreboot_configurator.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/cc2aca0f_1d92eaf5 PS1, Line 25: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/ab24bf40_de384200 PS1, Line 25: public: labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/0280b96c_7870bd7a PS1, Line 26: coreboot_configurator(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/b6a5ddca_211e9543 PS1, Line 29: std::string cfgpath_s; labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/10451fc4_07376bd3 PS1, Line 63: std::map<std::string, int> gfx_map; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/c618b049_4f9b9959 PS1, Line 63: std::map<std::string, int> gfx_map; spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/6c811f08_2c3826cd PS1, Line 63: std::map<std::string, int> gfx_map; labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/f18cc3e6_74760d89 PS1, Line 64: std::map<std::string, int> device_map; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/c50b8c8c_739a528d PS1, Line 64: std::map<std::string, int> device_map; spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/f04e20ad_c0ee3f58 PS1, Line 64: std::map<std::string, int> device_map; labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/ef3ae274_9bed3174 PS1, Line 72: protected: labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/f31f7d19_e0c89e39 PS1, Line 73: void showEvent(QShowEvent *ev); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/e98e3747_c53f86d4 PS1, Line 76: public slots: please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/7b21665a_996cc254 PS1, Line 76: public slots: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/2062ba72_23448dac PS1, Line 79: void saveAndClose(); Bad function definition - void saveAndClose() should probably be void saveAndClose(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/dcc654a1_b35bbe21 PS1, Line 86: void getSettings(); Bad function definition - void getSettings() should probably be void getSettings(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/46c5b368_81f398c1 PS1, Line 87: void getFromFile(); Bad function definition - void getFromFile() should probably be void getFromFile(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/81f3b1ad_cb1439ab PS1, Line 91: void writeSettings(); Bad function definition - void writeSettings() should probably be void writeSettings(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/65a7ce93_8b1f2436 PS1, Line 95: private: labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/b33a733e_88bdb1fe PS1, Line 97: void textToDisplay(QStringList str_list, std::string in_string, QComboBox *box); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/14ac124b_8fe93f49 PS1, Line 102: void checkToFile(std::fstream &output, std::string precursor, QCheckBox *box); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/0d18d8a1_355d8a99 PS1, Line 103: void comboToFile(std::fstream &output, std::string precursor, QComboBox *box, need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/db37bd1a_ae39762a PS1, Line 104: std::string successor); labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/5df7ff05_0cfbad10 PS1, Line 105: void sliderToFile(std::fstream &output, std::string precursor, QSlider *slider); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/7458de35_54da33aa PS1, Line 106: void lineToFile(std::fstream &output, QLineEdit *line); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/c904e795_435a4520 PS1, Line 108: Ui::coreboot_configurator *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/13dc9bbe_4e8d7ea2 PS1, Line 108: Ui::coreboot_configurator *ui; labels should not be indented
File util/coreboot-configurator/src/labtop-series/readcfg.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/7871dcaa_2c49efdb PS1, Line 9: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/4046bc40_ddf1d638 PS1, Line 9: public: labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/3d608883_ce04a07a PS1, Line 12: std::string values[25]; labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/f61f66bc_b0416c6a PS1, Line 13: void get_values(); Bad function definition - void get_values() should probably be void get_values(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/68a90f25_b62fee82 PS1, Line 15: private: labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/53e397dc_035739e6 PS1, Line 16: std::string in_file; labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/cbcab8a9_3530e43f PS1, Line 17: std::string shrink_string(std::string input); labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132024): https://review.coreboot.org/c/coreboot/+/58854/comment/44a4cbea_af2744a0 PS1, Line 19: signals: labels should not be indented