Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32614 )
Change subject: soc/skl/memmap: calculate mem size even if IGD undefined in devtree
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32614/2/src/soc/intel/skylake/memmap.c
File src/soc/intel/skylake/memmap.c:
https://review.coreboot.org/#/c/32614/2/src/soc/intel/skylake/memmap.c@175
PS2, Line 175: idg
igd?
Thank you for review. Perhaps at that moment I was thinking about "Integrated Discrete Graphics" :) but igd_dev looks better.
I renamed it to igd_dev
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32614
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3da51473e6c06da803bd969a4a6dff792c18f962
Gerrit-Change-Number: 32614
Gerrit-PatchSet: 3
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 07 May 2019 08:30:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment