Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46303 )
Change subject: drivers/soundwire/alc711: Add Realtek ALC711 soundwire device
......................................................................
Patch Set 6: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/46303/5/src/drivers/soundwire/alc71...
File src/drivers/soundwire/alc711/alc711.c:
https://review.coreboot.org/c/coreboot/+/46303/5/src/drivers/soundwire/alc71...
PS5, Line 59: dp1
nit: might just name this 'dp' since it is being applied to both dp1 and dp2.
Done
https://review.coreboot.org/c/coreboot/+/46303/5/src/drivers/soundwire/alc71...
PS5, Line 128: \
should be able to just remove the \ here
Done
https://review.coreboot.org/c/coreboot/+/46303/5/src/include/device/mipi_ids...
File src/include/device/mipi_ids.h:
https://review.coreboot.org/c/coreboot/+/46303/5/src/include/device/mipi_ids...
PS5, Line 23: 0x0711
Nit: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46303
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia7358927fe8531e609ebe070bef259a2bbc09093
Gerrit-Change-Number: 46303
Gerrit-PatchSet: 6
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 16 Oct 2020 21:21:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment