Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35303 )
Change subject: mb/google/drallion: Enable 360 sensor detection
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35303/7/src/mainboard/google/dralli...
File src/mainboard/google/drallion/variants/drallion/gpio.c:
https://review.coreboot.org/c/coreboot/+/35303/7/src/mainboard/google/dralli...
PS7, Line 283: int
This can now be static. It is not used outside this file.
https://review.coreboot.org/c/coreboot/+/35303/7/src/soc/intel/cannonlake/in...
File src/soc/intel/cannonlake/include/soc/romstage.h:
https://review.coreboot.org/c/coreboot/+/35303/7/src/soc/intel/cannonlake/in...
PS7, Line 24: void variant_mainboard_memory_init_params(FSPM_UPD *mupd);
You don't need this here. It can live in variants.h in mainboard/google/drallion.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35303
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22fafb43dce6545851883be556a02d65a01fc386
Gerrit-Change-Number: 35303
Gerrit-PatchSet: 7
Gerrit-Owner: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: AndreX Andraos
andrex.andraos@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 12 Sep 2019 01:01:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment