Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33001 )
Change subject: soc/intel/common/cse: Don't use CAR_GLOBAL
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/33001/5/src/soc/intel/common/block/cse/cse.c
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/#/c/33001/5/src/soc/intel/common/block/cse/cse.c...
PS5, Line 71: struct cse_device {
Could be static?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33001
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If952ad8129e1fa6e45858cb77ec99c9fec55c4a6
Gerrit-Change-Number: 33001
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 27 May 2019 15:04:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment