Name of user not set #1002789 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44005 )
Change subject: drivers/generic/cbfs-serial: Update driver to read UUID from CBFS ......................................................................
Patch Set 3:
(4 comments)
Made changes as requested. Thank you for your feedback.
https://review.coreboot.org/c/coreboot/+/44005/1/src/drivers/generic/cbfs-se... File src/drivers/generic/cbfs-serial/cbfs-serial.c:
https://review.coreboot.org/c/coreboot/+/44005/1/src/drivers/generic/cbfs-se... PS1, Line 44: UUID_LENGTH
Please use UUID_STRLEN from `uuid.h` instead. The length has to match […]
Ack
https://review.coreboot.org/c/coreboot/+/44005/1/src/drivers/generic/cbfs-se... PS1, Line 47: if (system_uuid[0] != 0)
Nit, it could be 0 by coincidence. Also, I doubt this function is called […]
Sorry, I missed this in patchset 2. Pushing set 3 now...
https://review.coreboot.org/c/coreboot/+/44005/1/src/drivers/generic/cbfs-se... PS1, Line 57: uuid_len <= UUID_LENGTH
`uuid_len == sizeof(system_uuid) - 1` would make it most safe.
Ack
https://review.coreboot.org/c/coreboot/+/44005/1/src/drivers/generic/cbfs-se... PS1, Line 66: parse_uuid(uuid, system_uuid);
This line seems quite redundant.
Ack