David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38434 )
Change subject: nb/intel/haswell: Do some cosmetic fixes ......................................................................
Patch Set 7: Code-Review-1
(2 comments)
This looks good overall, thanks for doing it! There's one tiny correction and one minor suggestion (feel free to implement it or not).
https://review.coreboot.org/c/coreboot/+/38434/7/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/bootblock.c:
https://review.coreboot.org/c/coreboot/+/38434/7/src/northbridge/intel/haswe... PS7, Line 24: is set to to "is set to"
https://review.coreboot.org/c/coreboot/+/38434/7/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/haswell.h:
https://review.coreboot.org/c/coreboot/+/38434/7/src/northbridge/intel/haswe... PS7, Line 117: #define MCHBAR8(x) (*((volatile u8 *)(DEFAULT_MCHBAR + (x)))) Can the casts in these macros (as well as EPBAR() and DMIBAR()) be replaced with accessors from mmio.h? For example: #define MCHBAR8(x) read8(DEFAULT_MCHBAR + (x))