Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32527 )
Change subject: soc/intel/cannonlake: Dump ME f/w version and status information. ......................................................................
Patch Set 7:
Subrata, can you please confirm that your Heci disabling changes have no impact on the dump_me_status? Or if you can provide the steps to test it out to Tim, he should be able to check it as well.
yes, it will have impact for sure, because dump_me_status relying on PCI config register which will be read as 0xFF hence i have recommended to move this code from state machine to fixed call from finalized.c and dump me status just before and make HECI disable.
You can take example of KBL based platform, log below
Finalizing chipset. ME: FW Partition Table : OK ME: Bringup Loader Failure : NO ME: Firmware Init Complete : YES ME: Manufacturing Mode : YES ME: Boot Options Present : NO ME: Update In Progress : NO ME: D3 Support : NO ME: D0i3 Support : YES ME: Low Power State Enabled : YES ME: Power Gated : NO ME: CPU Replaced : NO ME: CPU Replacement Valid : NO ME: Current Working State : Normal ME: Current Operation State : M0 with UMA ME: Current Operation Mode : Normal ME: Error Code : No Error ME: Progress Phase : Unknown (8) ME: Power Management Event : Clean Intel ME reset ME: Progress Phase State : Unknown phase: 0x08 state: 0x10 ME: Power Down Mitigation : NO ME: FPF status : unfused